Expose sampling controls in assistants (#955) #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarrazin
added
enhancement
This reverts commit 1b44086.
gary149
approved these changes
Mar 27, 2024
mishig25
reviewed
Mar 27, 2024
Co-authored-by: Mishig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It opens by default if values are prefilled. I updated the endpoint code so it should work with every endpoint type. There's a tooltip for each field that works on mobile & desktop.
Had to deviate a bit from the design in #955, it was hard to fit the label and the field horizontally (only looked good on big screen at full width) so I ended up putting the label above the field.
Also used the native html details/summary elements instead of a button, and added a border around the content, otherwise it was easy to confuse with the user start messages below.