Limit number of fetched conversations in the API #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @alak, we had a limit in the load function for the web app to avoid loading too many conversations at once, ported it over to the API endpoint with added pagination 😄 |
alak
approved these changes
Mar 25, 2024
mishig25
reviewed
Mar 25, 2024
Comment on lines
19
to
20
| .skip(300 * p) | ||
| .limit(300) |
There was a problem hiding this comment.
Suggested change
| .skip(300 * p) | |
| .limit(300) | |
| .skip(NUM_PER_PAGE * p) | |
| .limit(NUM_PER_PAGE) |
and declaring const NUM_PER_PAGE = 300; above would be more robust since skip & limit should be tied with one another through a variable
There was a problem hiding this comment.
Should we make it an env var? So it's also tied to the one in the load function ?
There was a problem hiding this comment.
up to you. For me, it is fine as long as it is a variable here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing the same limit that we use in the load function of the web app.