Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃毟 When a user signs up they're directly logged in #952

Merged
merged 2 commits into from Mar 22, 2024
Merged

馃毟 When a user signs up they're directly logged in #952

merged 2 commits into from Mar 22, 2024

Conversation

coyotte508
Copy link
Member

@coyotte508 coyotte508 commented Mar 22, 2024 •
edited

Currently it seems a user, when logging in for the first time, needs to

  • sign up (with "sign in with HF")
  • sign in

Because the sign up doesn't send the new cookie value to the user

nsarrazin
nsarrazin approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@nsarrazin nsarrazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! I've been trying on and off to figure out what was going wrong, couldn't track it down, merging right away 馃帀

@nsarrazin nsarrazin merged commit 506e596 into main Mar 22, 2024
3 checks passed
@nsarrazin nsarrazin deleted the fix-signup-logged-in branch March 22, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alak alak alak approved these changes

@nsarrazin nsarrazin nsarrazin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coyotte508 @alak @nsarrazin