Set assistant prompt from URL #942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarrazin
added
enhancement
gary149
reviewed
Mar 19, 2024
Comment on lines
+124
to
+144
| formData.set("ragPrepromptUrl", ""); | ||
| } else if (ragMode === "all") { | ||
| formData.set("ragAllowAll", "true"); | ||
| formData.set("ragLinkList", ""); | ||
| formData.set("ragDomainList", ""); | ||
| formData.set("ragPrepromptUrl", ""); | ||
| } else if (ragMode === "links") { | ||
| formData.set("ragAllowAll", "false"); | ||
| formData.set("ragDomainList", ""); | ||
| formData.set("ragPrepromptUrl", ""); | ||
| } else if (ragMode === "domains") { | ||
| formData.set("ragAllowAll", "false"); | ||
| formData.set("ragLinkList", ""); | ||
| formData.set("ragPrepromptUrl", ""); | ||
| } else if (ragMode === "preprompt") { | ||
| formData.set("ragAllowAll", "false"); | ||
| formData.set("ragLinkList", ""); | ||
| formData.set("ragDomainList", ""); | ||
| formData.set( | ||
| "preprompt", | ||
| "The system prompt input is disabled when using a system prompt URL." |
There was a problem hiding this comment.
We could just refactor later no? I don't get why we need this list this should be handled natively by the <form>.
gary149
reviewed
Mar 19, 2024
Co-authored-by: Victor Muštar <[email protected]>
gary149
reviewed
Mar 19, 2024
| // if the assistant has a preprompt Url and it's not local, try to fetch it | ||
| if (assistant.rag?.prepromptUrl && !(await isURLLocal(new URL(assistant.rag.prepromptUrl)))) { | ||
| try { | ||
| const content = await parseWeb(assistant.rag.prepromptUrl); |
There was a problem hiding this comment.
I would not parse like for web content.
|
I think, this will be a very useful feature. 👍 But I would suggest to make the internet access features composable, so that web search, prompts from URLs, etc. can be used together if desired. In that case, the settings UI could be structured this way:
Related to this feature:
|
|
Closing in favour of #949 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assistant view
Settings edit/new
This uses the same
parseWebmethod we use in the web search, but instead of chunking and generating embeddings we just add the resulting text to the system prompt.