Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prompt bypasses login #921

Merged
merged 1 commit into from Mar 11, 2024
Merged

fix: Prompt bypasses login #921

merged 1 commit into from Mar 11, 2024

Conversation

KartikGS
Copy link
Contributor

@KartikGS KartikGS commented Mar 9, 2024 •
edited

@nsarrazin nsarrazin self-requested a review March 10, 2024 19:54
nsarrazin
nsarrazin approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@nsarrazin nsarrazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly, thanks for the fix! 🚀

@nsarrazin nsarrazin merged commit 2edb278 into huggingface:main Mar 11, 2024
3 checks passed
@KartikGS KartikGS deleted the fix/prompt_bypassed_login branch March 14, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsarrazin nsarrazin nsarrazin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Starting a conversation with a prompt example bypasses the login modal
2 participants
@KartikGS @nsarrazin