Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove double meta tags on models page #918

Merged
merged 2 commits into from Mar 8, 2024
Merged

Remove double meta tags on models page #918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6efd34
Remove double meta tags
nsarrazin Mar 8, 2024
2c0cf6d
Remove unknown property
nsarrazin Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/routes/+layout.svelte
View file
Open in desktop
Expand Up @@ -140,7 +140,7 @@

<!-- use those meta tags everywhere except on the share assistant page -->
<!-- feel free to refacto if there's a better way -->
{#if !$page.url.pathname.includes("/assistant/") && $page.route.id !== "/assistants"}
{#if !$page.url.pathname.includes("/assistant/") && $page.route.id !== "/assistants" && !$page.url.pathname.includes("/models/")}
<meta property="og:title" content={PUBLIC_APP_NAME} />
<meta property="og:type" content="website" />
<meta property="og:url" content="{PUBLIC_ORIGIN || $page.url.origin}{base}" />
Expand Down
2 changes: 1 addition & 1 deletion src/routes/models/[...model]/+page.svelte
View file
Open in desktop
Expand Up @@ -82,7 +82,7 @@
<svelte:head>
<meta property="og:title" content={modelId + " - " + PUBLIC_APP_NAME} />
<meta property="og:type" content="link" />
<meta property="og:description" content={`Use ${modelId} inside of ${PUBLIC_APP_NAME}`} />
<meta property="og:description" content={`Use ${modelId} with ${PUBLIC_APP_NAME}`} />
<meta
property="og:image"
content="{PUBLIC_ORIGIN || $page.url.origin}{base}/models/{modelId}/thumbnail.png"
Expand Down
2 changes: 1 addition & 1 deletion src/routes/models/[...model]/thumbnail.png/ModelThumbnail.svelte
View file
Open in desktop
Expand Up @@ -9,7 +9,7 @@
</script>

<div class=" flex h-[648px] w-full flex-col items-center bg-white">
<div class="flex flex-1 flex-col items-center justify-center gap-2">
<div class="flex flex-1 flex-col items-center justify-center">
{#if logoUrl}
<img class="h-48 w-48" src={logoUrl} alt="avatar" />
{/if}
Expand Down