Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include last chunk in websearch context #912

Merged
merged 2 commits into from Mar 7, 2024
Merged

Conversation

nsarrazin
Copy link
Collaborator

While working on RAG for assistants, I noticed that the last chunk was always missing from the websearch context. In my case it was quite important because my context only had one chunk 馃槅

@nsarrazin nsarrazin added bug Something isn't working websearch labels Mar 7, 2024
@nsarrazin nsarrazin requested a review from mishig25 March 7, 2024 09:45
@nsarrazin nsarrazin changed the title Include last chunk in websearch embedding Include last chunk in websearch context Mar 7, 2024
Copy link
Collaborator

@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@nsarrazin nsarrazin merged commit 8e839b8 into main Mar 7, 2024
3 checks passed
@nsarrazin nsarrazin deleted the fix/websearch_index branch March 7, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working websearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants