Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Dynamic User Attribute Handling in OIDC Integration #885

Merged
merged 10 commits into from Mar 22, 2024
Merged

Enhance Dynamic User Attribute Handling in OIDC Integration #885

merged 10 commits into from Mar 22, 2024

Conversation

mcc311
Copy link
Contributor

@mcc311 mcc311 commented Feb 28, 2024 •
edited

Add nameClaim in .env for those OpenID Provider which don't use name as default identifier.

@mcc311
Copy link
Contributor Author

mcc311 commented Mar 8, 2024 •
edited

@nsarrazin Sorry for the Prettier problem. I have pushed a newer version fixing this.

@nsarrazin
Copy link
Collaborator

No worries! Am reviewing the PR itself and it looks good, I'll fix any linting problems if there are any 😄

@nsarrazin nsarrazin self-requested a review March 8, 2024 13:48
@nsarrazin
Copy link
Collaborator

@mcc311 Sorry for the delay! I changed a few things in c0d98cf and bc25544, if the feature still works for you then I think we could merge this 😄

mcc311
mcc311 commented Mar 22, 2024
View reviewed changes
Copy link
Contributor Author

@mcc311 mcc311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think the change is great!

nsarrazin
nsarrazin approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@nsarrazin nsarrazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Will merge this right after 🚀

@nsarrazin nsarrazin merged commit c6129c3 into huggingface:main Mar 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsarrazin nsarrazin nsarrazin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcc311 @nsarrazin