Skip to content

Enhance Dynamic User Attribute Handling in OIDC Integration - #885

Merged
nsarrazin merged 10 commits into
huggingface:mainfrom
mcc311:main
Mar 22, 2024
Merged

nsarrazin merged 10 commits into
huggingface:mainfrom
mcc311:main

Conversation

@mcc311

@mcc311 mcc311 commented Feb 28, 2024 •

Copy link
Copy Markdown
Contributor

Add nameClaim in .env for those OpenID Provider which don't use name as default identifier.

@mcc311

mcc311 commented Mar 8, 2024 •

Copy link
Copy Markdown
Contributor Author

@nsarrazin Sorry for the Prettier problem. I have pushed a newer version fixing this.

@nsarrazin

Copy link
Copy Markdown
Contributor

No worries! Am reviewing the PR itself and it looks good, I'll fix any linting problems if there are any 😄

@nsarrazin
nsarrazin self-requested a review March 8, 2024 13:48
@nsarrazin

Copy link
Copy Markdown
Contributor

@mcc311 Sorry for the delay! I changed a few things in c0d98cf and bc25544, if the feature still works for you then I think we could merge this 😄

@mcc311 mcc311 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think the change is great!

@nsarrazin nsarrazin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Will merge this right after 🚀

@nsarrazin
nsarrazin merged commit c6129c3 into huggingface:main Mar 22, 2024
ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
…ace#885)

* Refactor `updateUser` to Support Dynamic `nameClaim` Configuration

* style: run Prettier to fix lint errors

* Validate NAME_CLAIM in OIDConfig schema

* Refactor userData parsing

---------

Co-authored-by: Nathan Sarrazin <sarrazin.nathan@gmail.com>
Co-authored-by: ‘XGungo’ <‘daniel2000890311g@gmail.com’>
maksym-work pushed a commit to siilats/chat-ui that referenced this pull request Jul 2, 2025
…ace#885)

* Refactor `updateUser` to Support Dynamic `nameClaim` Configuration

* style: run Prettier to fix lint errors

* Validate NAME_CLAIM in OIDConfig schema

* Refactor userData parsing

---------

Co-authored-by: Nathan Sarrazin <sarrazin.nathan@gmail.com>
Co-authored-by: ‘XGungo’ <‘daniel2000890311g@gmail.com’>
Matsenas pushed a commit to Matsenas/chat-ui that referenced this pull request Jul 4, 2025
…ace#885)

* Refactor `updateUser` to Support Dynamic `nameClaim` Configuration

* style: run Prettier to fix lint errors

* Validate NAME_CLAIM in OIDConfig schema

* Refactor userData parsing

---------

Co-authored-by: Nathan Sarrazin <sarrazin.nathan@gmail.com>
Co-authored-by: ‘XGungo’ <‘daniel2000890311g@gmail.com’>
Matsenas pushed a commit to Matsenas/chat-ui that referenced this pull request Jul 4, 2025
…ace#885)

* Refactor `updateUser` to Support Dynamic `nameClaim` Configuration

* style: run Prettier to fix lint errors

* Validate NAME_CLAIM in OIDConfig schema

* Refactor userData parsing

---------

Co-authored-by: Nathan Sarrazin <sarrazin.nathan@gmail.com>
Co-authored-by: ‘XGungo’ <‘daniel2000890311g@gmail.com’>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants