Bug Fix: Json Decoder aggessively pulls json #867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Had this problem on 2 different setups, essentially the decoder for llamacpp would grab partially streamed json and decode it without the new line
Description
Just wait until we see a new line character before trying to decode the json. if we fail to decode a token, just toss it. *may lead to tokens being thrown out but after a couple of days of running this thru the ringer it seemed to work, and dropping a word is a better UX than just crashing when it fails to decode the response