-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: add sources for websearch #1551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aaditya Sahay <[email protected]>
Contributor
Author
|
doesnt work well with tools, investigating. works well for models that dont have tools enabled |
Contributor
Author
|
works well enough without tools, will merge for now, failure mode is usually just that it forgets to put citations so it's not really breaking |
maksym-work
pushed a commit
to siilats/chat-ui
that referenced
this pull request
Jul 2, 2025
* feat: playwright, spatial parsing, markdown for web search Co-authored-by: Aaditya Sahay <[email protected]> * feat: choose multiple clusters if necessary (huggingface#2) * chore: resolve linting failures * feat: improve paring performance and error messages * feat: inline citations * feat: adjust inline citation prompt, less intrusive tokens * feat: add sources to message when using websearch * fix: clean up packages * fix: packages * fix: packages lol * fix: make websearch citation work better wiht tools * fix: use single brackets for sources, only render source element if a matching source is available * fix: bad import --------- Co-authored-by: Liam Dyer <[email protected]> Co-authored-by: Aaditya Sahay <[email protected]> Co-authored-by: Aaditya Sahay <[email protected]>
Matsenas
pushed a commit
to Matsenas/chat-ui
that referenced
this pull request
Jul 4, 2025
* feat: playwright, spatial parsing, markdown for web search Co-authored-by: Aaditya Sahay <[email protected]> * feat: choose multiple clusters if necessary (huggingface#2) * chore: resolve linting failures * feat: improve paring performance and error messages * feat: inline citations * feat: adjust inline citation prompt, less intrusive tokens * feat: add sources to message when using websearch * fix: clean up packages * fix: packages * fix: packages lol * fix: make websearch citation work better wiht tools * fix: use single brackets for sources, only render source element if a matching source is available * fix: bad import --------- Co-authored-by: Liam Dyer <[email protected]> Co-authored-by: Aaditya Sahay <[email protected]> Co-authored-by: Aaditya Sahay <[email protected]>
Matsenas
pushed a commit
to Matsenas/chat-ui
that referenced
this pull request
Jul 4, 2025
* feat: playwright, spatial parsing, markdown for web search Co-authored-by: Aaditya Sahay <[email protected]> * feat: choose multiple clusters if necessary (huggingface#2) * chore: resolve linting failures * feat: improve paring performance and error messages * feat: inline citations * feat: adjust inline citation prompt, less intrusive tokens * feat: add sources to message when using websearch * fix: clean up packages * fix: packages * fix: packages lol * fix: make websearch citation work better wiht tools * fix: use single brackets for sources, only render source element if a matching source is available * fix: bad import --------- Co-authored-by: Liam Dyer <[email protected]> Co-authored-by: Aaditya Sahay <[email protected]> Co-authored-by: Aaditya Sahay <[email protected]>
gary149
pushed a commit
to gary149/chat-ui
that referenced
this pull request
Aug 29, 2025
* feat: playwright, spatial parsing, markdown for web search Co-authored-by: Aaditya Sahay <[email protected]> * feat: choose multiple clusters if necessary (#2) * chore: resolve linting failures * feat: improve paring performance and error messages * feat: inline citations * feat: adjust inline citation prompt, less intrusive tokens * feat: add sources to message when using websearch * fix: clean up packages * fix: packages * fix: packages lol * fix: make websearch citation work better wiht tools * fix: use single brackets for sources, only render source element if a matching source is available * fix: bad import --------- Co-authored-by: Liam Dyer <[email protected]> Co-authored-by: Aaditya Sahay <[email protected]> Co-authored-by: Aaditya Sahay <[email protected]>
gary149
pushed a commit
to gary149/chat-ui
that referenced
this pull request
Aug 29, 2025
* feat: playwright, spatial parsing, markdown for web search Co-authored-by: Aaditya Sahay <[email protected]> * feat: choose multiple clusters if necessary (#2) * chore: resolve linting failures * feat: improve paring performance and error messages * feat: inline citations * feat: adjust inline citation prompt, less intrusive tokens * feat: add sources to message when using websearch * fix: clean up packages * fix: packages * fix: packages lol * fix: make websearch citation work better wiht tools * fix: use single brackets for sources, only render source element if a matching source is available * fix: bad import --------- Co-authored-by: Liam Dyer <[email protected]> Co-authored-by: Aaditya Sahay <[email protected]> Co-authored-by: Aaditya Sahay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #1118, branch had a lot of conflicts