Make sure we properly close the stream when done (#891)

huggingface · Mar 1, 2024 · 7a3c71d · 7a3c71d
1 parent 6e801f2
commit 7a3c71d
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/routes/conversation/[id]/+page.svelte b/src/routes/conversation/[id]/+page.svelte
@@ -224,9 +224,16 @@
 
  // this is a bit ugly
  // we read the stream until we get the final answer
+
+ let readerClosed = false;
+
+ reader.closed.then(() => {
+ readerClosed = true;
+ });
+
  while (finalAnswer === "") {
  // check for abort
- if ($isAborted || $error) {
+ if ($isAborted || $error || readerClosed) {
  reader?.cancel();
  break;
  }
@@ -236,7 +243,6 @@
  // we read, if it's done we cancel
  if (done) {
  reader.cancel();
- return;
  }
 
  if (!value) {