Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 [i18n-KO] docs: ko: Chap3 Transformer architectures for audio #94

Merged
merged 9 commits into from
Jul 24, 2023
Merged

🌐 [i18n-KO] docs: ko: Chap3 Transformer architectures for audio #94

merged 9 commits into from
Jul 24, 2023

Conversation

gabrielwithappy
Copy link
Contributor

@gabrielwithappy gabrielwithappy commented Jul 13, 2023 •
edited
Loading

What does this PR do?

Translated the multiple_choice.mdx file of the documentation to Korean.
Feel free to discuss about this PR on discord channel
Thank you in advance for your review.

Part of #67

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

@jungnerd @jinnsp @wonhyeongseo

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? or discord Please add a link
    to it if that's the case.
  • Did you write any new necessary tests?

Who can review? (Final)

May you please review this PR?
@MKhalusova

@gabrielwithappy gabrielwithappy changed the title 🌐 [i18n-KO] docs: ko: Chap3 🌐 [i18n-KO] docs: ko: Chap3 Transformer Architectures For Audio Jul 13, 2023
@gabrielwithappy gabrielwithappy changed the title 🌐 [i18n-KO] docs: ko: Chap3 Transformer Architectures For Audio 🌐 [i18n-KO] docs: ko: Chap3 Transformer architectures for audio Jul 14, 2023
@gabrielwithappy gabrielwithappy marked this pull request as ready for review July 14, 2023 23:23
@gabrielwithappy gabrielwithappy changed the title 🌐 [i18n-KO] docs: ko: Chap3 Transformer architectures for audio 🌐 [WIP][i18n-KO] docs: ko: Chap3 Transformer architectures for audio Jul 14, 2023
@gabrielwithappy
Copy link
Contributor Author

@jungnerd @jinnsp @wonhyeongseo
Please review this PR :-)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 18, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@MKhalusova
Copy link
Contributor

Is the PR ready for review?

@gabrielwithappy gabrielwithappy changed the title 🌐 [WIP][i18n-KO] docs: ko: Chap3 Transformer architectures for audio 🌐 [i18n-KO] docs: ko: Chap3 Transformer architectures for audio Jul 18, 2023
@gabrielwithappy
Copy link
Contributor Author

gabrielwithappy commented Jul 19, 2023 •
edited
Loading

Is the PR ready for review?

The job is done. I am waiting for reviews from Korean reviewers. Though I am also asking to huggingface discord channel, no reviews so far. 😭
If there is no problem, I would appreciate it if you could review or run a live preview 🙂

@gabrielwithappy
Copy link
Contributor Author

gabrielwithappy commented Jul 19, 2023 •
edited
Loading

update doc.

  • fix some toc title and ambiguous sentences
  • translate missing sentenses

@gabrielwithappy
Copy link
Contributor Author

Dear @MKhalusova,
Thank you for a live preview
I found my mistakes and fix some toc title and ambiguous sentences.
Please review this PR :-)
BRs

gabrielwithappy
gabrielwithappy commented Jul 20, 2023
View reviewed changes
Copy link
Contributor Author

@gabrielwithappy gabrielwithappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refine korean sentenses

chapters/ko/chapter3/classification.mdx Outdated Show resolved Hide resolved
chapters/ko/chapter3/classification.mdx Outdated Show resolved Hide resolved
chapters/ko/chapter3/classification.mdx Outdated Show resolved Hide resolved
chapters/ko/chapter3/ctc.mdx Outdated Show resolved Hide resolved
chapters/ko/chapter3/ctc.mdx Outdated Show resolved Hide resolved
chapters/ko/chapter3/introduction.mdx Outdated Show resolved Hide resolved
chapters/ko/chapter3/introduction.mdx Outdated Show resolved Hide resolved
chapters/ko/chapter3/quiz.mdx Outdated Show resolved Hide resolved
@gabrielwithappy
refine korean sentenses
0ab8092 
refine korean sentenses
@gabrielwithappy
Update chapters/ko/chapter3/introduction.mdx
45bf7e6 
Add abbreviation description
@gabrielwithappy
Copy link
Contributor Author

  • refine korean sentenses
  • add abbreviation description

@gabrielwithappy
Copy link
Contributor Author

Dear @MKhalusova,
Please reivew this PR and run a live preview :-)
thank you in advance.
BRs.

@wonhyeongseo
Copy link

Hello @gabrielwithappy , I believe this PR's live-preview from the 2nd comment is still alive! 😺

@gabrielwithappy
Copy link
Contributor Author

Hello @gabrielwithappy , I believe this PR's live-preview from the 2nd comment is still alive! 😺

Thx a million 🤩

@gabrielwithappy
Copy link
Contributor Author

Dear @MKhalusova,
Please reivew this PR
thank you in advance.
BRs.

MKhalusova
MKhalusova reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@MKhalusova MKhalusova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work! It looks great to me, only one small improvement is required in order to merge. The order in the TOC is slightly off, please see my comment

chapters/ko/_toctree.yml Outdated Show resolved Hide resolved
@gabrielwithappy
Copy link
Contributor Author

Dear @MKhalusova,
Thank you for your kind review. I fixed it.
Please review this PR.

In addition, I've learn a lot from this course. :-)
BRs

MKhalusova
MKhalusova approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@MKhalusova MKhalusova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the feedback!

@MKhalusova MKhalusova merged commit bd8083b into huggingface:main Jul 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKhalusova MKhalusova MKhalusova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrielwithappy @HuggingFaceDocBuilderDev @MKhalusova @wonhyeongseo