Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated zh-CN Chapter 6 #175

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Translated zh-CN Chapter 6 #175

merged 2 commits into from
Mar 27, 2024

Conversation

kaleo996
Copy link
Contributor

Finished translating Chapter 6 into zh-CN. Please review and tell me to correct if there are any mistakes 😊. @MKhalusova

kaleo996 and others added 2 commits March 26, 2024 11:11
Sorry, I have accidentally written <Tip><Tip> instead of <Tip></Tip>.
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kaleo996
Copy link
Contributor Author

It looks good to me now. The titles of the chapters showed in the content are currently not in a consistent style, but I have unified them with kerning in my local repo, and will open another PR to push them along with chapter7 of zh-CN a few days later. Thank you for your patience! 🙂❤

@MKhalusova
Copy link
Contributor

The PR looks good to me. It would be great if @adeenayakup or someone from the community could check the translation.

Copy link

@Tsumugii24 Tsumugii24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your efforts and contributions, I reviewed them all and basically speaking the translation is accurate, but some things are still not so natural from the perspective of a Chinese native speaker. And I will be really grateful if you can help me review the translation of my PR for Chapter8!

@kaleo996
Copy link
Contributor Author

Sorry, I'm afraid that I don't have write access, so my review is not sufficient to approve your PR. /(ㄒoㄒ)/~~ @Tsumugii24

@MKhalusova
Copy link
Contributor

Thanks for the review @Tsumugii24 !

@MKhalusova MKhalusova merged commit 0ef4929 into huggingface:main Mar 27, 2024
2 checks passed
@Tsumugii24
Copy link

Sorry, I'm afraid that I don't have write access, so my review is not sufficient to approve your PR. /(ㄒoㄒ)/~~ @Tsumugii24

maybe a simple review and approve comment may help maintainers and others know my work~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants