Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add turkish language to audio-transformers-course #141

Merged
merged 12 commits into from
Sep 27, 2023

Conversation

tanersekmen
Copy link

I have translated from chapter 0 to chapter 2 but If I have enough time to translate, I will do it. 🤗

@MKhalusova
Copy link
Contributor

Hi @tanersekmen ! Thanks a lot for translating the first few chapters. Two more files need to be updated in order to build the course in a new language - .github/workflows/build_documentation.yml and .github/workflows/build_pr_documentation.yml. 
Please add tr to the list of languages similar to how it's done here.

@tanersekmen
Copy link
Author

Hi @MKhalusova, okay.
I missed that part.

Copy link
Author

@tanersekmen tanersekmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add that part. can you check the update @MKhalusova ?

choices={[
{
text: "dB",
explain: "Hayır, genlik desibel (dB) cinsinden ölçülür.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
explain: "Hayır, genlik desibel (dB) cinsinden ölçülür.
explain: "Hayır, genlik desibel (dB) cinsinden ölçülür."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An unclosed string breakes the doc build.

@MKhalusova
Copy link
Contributor

cc @merveenoyan Can you please take a look at the Turkish translation?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 26, 2023

The documentation is not available anymore as the PR was closed or merged.

@tanersekmen
Copy link
Author

tanersekmen commented Sep 26, 2023

Hi @merveenoyan, can you check my PR when you have time? I can not see any problem in the preview section.

Copy link
Contributor

@MKhalusova MKhalusova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation looks good to me, I think we can merge now.

@MKhalusova MKhalusova merged commit 1ce5dbb into huggingface:main Sep 27, 2023
2 checks passed
@merveenoyan
Copy link
Contributor

merveenoyan commented Oct 2, 2023

@tanersekmen sanırım çeviride openai gibi bir model kullanıp kendiniz çevirmemişsiniz, benim bu PR'ı kaçırmam kötü olmuş. Bunu düzeltmek ne yazık ki çok vaktimi alacak, lütfen bir daha böyle bir PR açmayın. (ya da model aracılığıyla yaptığınızı belirtin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants