Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: SFTConfig type wrong #179

Closed
wants to merge 1 commit into from
Closed

BUG: SFTConfig type wrong #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/alignment/configs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import dataclasses
import os
import sys
import trl
from dataclasses import dataclass, field
from typing import Any, Dict, List, NewType, Optional, Tuple

Expand Down Expand Up @@ -235,7 +236,7 @@ class DataArguments:


@dataclass
class SFTConfig(transformers.TrainingArguments):
class SFTConfig(trl.SFTConfig):
"""
Arguments related to the training process itself. For all parameters, see: https://huggingface.co/docs/transformers/v4.26.1/en/main_classes/trainer#transformers.TrainingArguments
Also used for the continued pretraining task.
Expand All @@ -256,7 +257,7 @@ class SFTConfig(transformers.TrainingArguments):


@dataclass
class DPOConfig(transformers.TrainingArguments):
class DPOConfig(trl.SFTConfig):
"""
Arguments related to the DPO training process itself. For all parameters, see: https://huggingface.co/docs/transformers/v4.26.1/en/main_classes/trainer#transformers.TrainingArguments
"""
Expand Down