fix duplicate

huggingface · Jul 29, 2024 · 227deaa · 227deaa
1 parent 6045dff
commit 227deaa
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/alignment/configs.py b/src/alignment/configs.py
@@ -71,7 +71,7 @@ def parse_yaml_and_args(self, yaml_arg: str, other_args: Optional[List[str]] = N
                         inputs[arg] = [str(v) for v in val.split(",")]
 
                     # bool of a non-empty string is True, so we manually check for bools
-                    if base_type == bool:
+                    if base_type is bool:
                         if val in ["true", "True"]:
                             inputs[arg] = True
                         else:
@@ -187,7 +187,8 @@ class ModelArguments:
     )
     use_bnb_nested_quant: bool = field(default=False, metadata={"help": "use nested quantization"})
     bnb_4bit_quant_storage: Optional[str] = field(
-        default="uint8", metadata={"help": "storage type to pack the quanitzed 4-bit prarams."}
+        default="uint8",
+        metadata={"help": "storage type to pack the quanitzed 4-bit prarams."},
     )
 
     def __post_init__(self):
@@ -246,9 +247,6 @@ class SFTConfig(trl.SFTConfig):
         default="main",
         metadata={"help": ("The Hub model branch to push the model to.")},
     )
-    dataset_kwargs: Optional[Dict[str, Any]] = field(
-        default=None, metadata={"help": "Dataset kwargs for the SFTTrainer"}
-    )
     logging_first_step: bool = field(
         default=True,
         metadata={"help": ("Whether to log and evaluate the first global_step or not.")},