Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign creation dialogs #652

Merged
merged 45 commits into from
Jan 22, 2025
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
18308fa
Stop writing map_groups.h
GriffinRichards Nov 11, 2024
b7d78b0
Make Map members private
GriffinRichards Nov 12, 2024
acaed90
Read map.json constants on project open
GriffinRichards Nov 12, 2024
9d87ece
New map popup/prompt to dialog
GriffinRichards Nov 12, 2024
d6a796e
Start new map dialog redesign
GriffinRichards Nov 12, 2024
9e1ef2c
Import collapsible section
GriffinRichards Nov 12, 2024
205bb48
Header tab and new map dialog share UI setup
GriffinRichards Nov 12, 2024
4f82243
Use collapsible section for header data in new map dialog
GriffinRichards Nov 12, 2024
7d7db38
Clean up new map dialog redesign
GriffinRichards Nov 12, 2024
8bb0100
Separate layout/header features of new map dialog
GriffinRichards Nov 12, 2024
724f420
Automatically add new map groups
GriffinRichards Nov 14, 2024
bd39bcf
Begin new layout dialog redesign
GriffinRichards Nov 19, 2024
e7df829
Group AdvanceMap parsing together, fix its tileset defaults
GriffinRichards Nov 21, 2024
d0101d8
Finish new layout dialog redesign
GriffinRichards Nov 21, 2024
4671321
Add item to duplicate map/layouts from list
GriffinRichards Nov 22, 2024
b230f21
Automatically add new MAPSEC values from New Map dialog
GriffinRichards Nov 24, 2024
ff04a41
Add map list tool tips / copy actions, simplify MapListModel
GriffinRichards Nov 26, 2024
f1a4b78
Fix map duplication
GriffinRichards Nov 26, 2024
6aa8802
Fix map list empty folder regression
GriffinRichards Nov 27, 2024
06a263c
Fix regression to map stitch images from layout split
GriffinRichards Nov 27, 2024
83ef14a
Fix some problems with layout directory creation
GriffinRichards Nov 27, 2024
ba4a43d
Reserve MAP_UNDEFINED
GriffinRichards Dec 3, 2024
b7c34a6
Fix AdvanceMap import memory leaks, revert name change
GriffinRichards Dec 3, 2024
9c40b04
Redesign new tileset dialog
GriffinRichards Dec 4, 2024
435d22c
Fix layouts list sorting by ID rather than name
GriffinRichards Dec 6, 2024
391f7b1
Reserve MAP_DYNAMIC, fix some MAPSEC displays not updating, new error…
GriffinRichards Dec 6, 2024
52a7cd4
Combine minor creation dialogs
GriffinRichards Dec 10, 2024
a6233e9
Ensure automatic new layout names are unique
GriffinRichards Dec 12, 2024
4209c3e
Fix checkerboard pattern for secondary tilesets
GriffinRichards Dec 12, 2024
bdd64a6
Use applicationName() for window titles, clean up some remaining TODO…
GriffinRichards Dec 14, 2024
bf38207
Add new QValidator classes
GriffinRichards Dec 14, 2024
59464aa
Fix possible crash when layout fails to open
GriffinRichards Dec 16, 2024
8f16822
Merge branch 'master' of https://github.com/huderlem/porymap into new…
GriffinRichards Dec 16, 2024
d9be7d5
Fix Qt5 build
GriffinRichards Dec 16, 2024
0d93977
Add QMessageBox convenience classes
GriffinRichards Dec 20, 2024
40adede
Fix editor's map/layout clearing if a map/layout fails to load
GriffinRichards Dec 23, 2024
8bd71a3
Merge branch 'master' of https://github.com/huderlem/porymap into new…
GriffinRichards Dec 23, 2024
72f37d8
Merge branch 'master' into new-map-dialog
GriffinRichards Dec 28, 2024
90c904e
Make it easier to edit MAPSEC names, Area -> Location
GriffinRichards Dec 28, 2024
f4c0cb2
Use placeholder text for new map/layout names
GriffinRichards Jan 22, 2025
cfb6f70
Fix freeze when creating a new tileset
GriffinRichards Jan 22, 2025
fe8f978
Fix map symbol editing regression, save new map/layout dialog geometry
GriffinRichards Jan 22, 2025
07e4d24
Enforce layout settings for duplicate maps
GriffinRichards Jan 22, 2025
a006362
Remove old layout suffix function
GriffinRichards Jan 22, 2025
0cf7a45
Don't automatically create empty MAPSEC display names
GriffinRichards Jan 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Finish new layout dialog redesign
GriffinRichards committed Nov 22, 2024
commit d0101d807e985615771274e1eb7666ebdbf3dd5f
4 changes: 2 additions & 2 deletions forms/mainwindow.ui
Original file line number Diff line number Diff line change
@@ -2926,7 +2926,7 @@
<addaction name="actionMap_Shift"/>
<addaction name="separator"/>
<addaction name="action_NewMap"/>
<addaction name="actionNew_Layout"/>
<addaction name="action_NewLayout"/>
<addaction name="actionNew_Tileset"/>
<addaction name="actionTileset_Editor"/>
<addaction name="actionRegion_Map_Editor"/>
@@ -3283,7 +3283,7 @@
<string>Grid Settings...</string>
</property>
</action>
<action name="actionNew_Layout">
<action name="action_NewLayout">
<property name="text">
<string>New Layout...</string>
</property>
87 changes: 54 additions & 33 deletions forms/newlayoutdialog.ui
Original file line number Diff line number Diff line change
@@ -2,8 +2,16 @@
<ui version="4.0">
<class>NewLayoutDialog</class>
<widget class="QDialog" name="NewLayoutDialog">
<property name="geometry">
<rect>
<x>0</x>
<y>0</y>
<width>264</width>
<height>173</height>
</rect>
</property>
<property name="windowTitle">
<string>New Map Options</string>
<string>New Layout Options</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
<item>
@@ -17,27 +25,36 @@
<x>0</x>
<y>0</y>
<width>238</width>
<height>146</height>
<height>106</height>
</rect>
</property>
<layout class="QGridLayout" name="gridLayout_3">
<property name="verticalSpacing">
<number>10</number>
</property>
<item row="2" column="0">
<widget class="QLabel" name="label_LayoutID">
<item row="1" column="1">
<widget class="QLabel" name="label_NameError">
<property name="visible">
<bool>false</bool>
</property>
<property name="styleSheet">
<string notr="true">color: rgb(255, 0, 0)</string>
</property>
<property name="text">
<string>Layout ID</string>
<string/>
</property>
<property name="wordWrap">
<bool>true</bool>
</property>
</widget>
</item>
<item row="0" column="1">
<widget class="QLineEdit" name="lineEdit_Name">
<item row="5" column="0" colspan="2">
<widget class="NewLayoutForm" name="newLayoutForm" native="true"/>
</item>
<item row="2" column="1">
<widget class="QLineEdit" name="lineEdit_LayoutID">
<property name="toolTip">
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;The name of the new map. The name cannot be the same as any other existing map.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
</property>
<property name="clearButtonEnabled">
<bool>true</bool>
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;The constant that will be used to refer to this layout. It cannot be the same as any other existing layout.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
</property>
</widget>
</item>
@@ -48,24 +65,25 @@
</property>
</widget>
</item>
<item row="3" column="1">
<widget class="QLabel" name="label_LayoutIDError">
<property name="visible">
<bool>false</bool>
</property>
<property name="styleSheet">
<string notr="true">color: rgb(255, 0, 0)</string>
</property>
<item row="2" column="0">
<widget class="QLabel" name="label_LayoutID">
<property name="text">
<string/>
<string>Layout ID</string>
</property>
<property name="wordWrap">
</widget>
</item>
<item row="0" column="1">
<widget class="QLineEdit" name="lineEdit_Name">
<property name="toolTip">
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;The name of the new layout. The name cannot be the same as any other existing layout.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
</property>
<property name="clearButtonEnabled">
<bool>true</bool>
</property>
</widget>
</item>
<item row="1" column="1">
<widget class="QLabel" name="label_NameError">
<item row="3" column="1">
<widget class="QLabel" name="label_LayoutIDError">
<property name="visible">
<bool>false</bool>
</property>
@@ -80,16 +98,6 @@
</property>
</widget>
</item>
<item row="2" column="1">
<widget class="QLineEdit" name="lineEdit_LayoutID">
<property name="toolTip">
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;The constant that will be used to refer to this map. It cannot be the same as any other existing map, and it must start with the specified prefix.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
</property>
</widget>
</item>
<item row="5" column="0" colspan="2">
<widget class="NewLayoutForm" name="newLayoutForm" native="true"/>
</item>
<item row="8" column="0" colspan="2">
<spacer name="verticalSpacer">
<property name="orientation">
@@ -107,6 +115,19 @@
</widget>
</widget>
</item>
<item>
<widget class="QLabel" name="label_GenericError">
<property name="styleSheet">
<string notr="true">color: rgb(255, 0, 0)</string>
</property>
<property name="text">
<string/>
</property>
<property name="wordWrap">
<bool>true</bool>
</property>
</widget>
</item>
<item>
<widget class="QDialogButtonBox" name="buttonBox">
<property name="standardButtons">
Loading