A few incident trigger tweaks #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Seekins <[email protected]>
Signed-off-by: John Seekins <[email protected]>
Signed-off-by: John Seekins <[email protected]>
Signed-off-by: John Seekins <[email protected]>
Signed-off-by: John Seekins <[email protected]>
Signed-off-by: John Seekins <[email protected]>
Signed-off-by: John Seekins <[email protected]>
Signed-off-by: John Seekins <[email protected]>
Signed-off-by: John Seekins <[email protected]>
Signed-off-by: John Seekins <[email protected]>
|
Both these functions are working correctly for us, but I'm happy to discuss how we could go about integrating them. |
stephenyeargin
approved these changes
Sep 28, 2024
There was a problem hiding this comment.
I don't have access to a live PagerDuty account these days, but everything here appears solid. If you'll npm version minor and push that up to the branch, I can get it merged. Thank you! 🚀
Unrelated, I added #229 because we need a bit more confidence that changes like this one won't inadvertently bust an existing workflow. It's been on the TODO list for a while.
stephenyeargin
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pager me <schedule> <minutes>didn't support quotes around the schedule name. This is inconsistent with every other case of schedule names. I think I fixed that up correctly.pager default triggerand send a message to a default schedule. I believe the changes I made around 160 should facilitate that, but would love some advice on how best to make that change.