Skip to content

Sort members for consistency #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025
Merged

Conversation

bitwiseman
Copy link
Member

@bitwiseman bitwiseman commented Apr 13, 2025

Description

Enforce the ordering of code. We don't have time to go popping around classes wondering where members might be found. Consistency is your friend.

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED" locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

Copy link

codecov bot commented Apr 13, 2025

Codecov Report

Attention: Patch coverage is 82.63666% with 270 lines in your changes missing coverage. Please review.

Project coverage is 85.01%. Comparing base (4d8d7c4) to head (73ab6c4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/org/kohsuke/github/GHIssue.java 78.35% 27 Missing and 2 partials ⚠️
...c/main/java/org/kohsuke/github/GHOrganization.java 75.21% 28 Missing and 1 partial ⚠️
src/main/java/org/kohsuke/github/GHProject.java 55.55% 20 Missing ⚠️
src/main/java/org/kohsuke/github/GHMyself.java 48.57% 18 Missing ⚠️
...java/org/kohsuke/github/GHCommitSearchBuilder.java 51.51% 15 Missing and 1 partial ⚠️
...ain/java/org/kohsuke/github/GHCheckRunBuilder.java 85.22% 7 Missing and 6 partials ⚠️
...c/main/java/org/kohsuke/github/GHIssueComment.java 62.96% 9 Missing and 1 partial ⚠️
src/main/java/org/kohsuke/github/GHCommit.java 88.70% 6 Missing and 1 partial ⚠️
src/main/java/org/kohsuke/github/GHContent.java 81.08% 5 Missing and 2 partials ⚠️
src/main/java/org/kohsuke/github/GHDiscussion.java 76.66% 3 Missing and 4 partials ⚠️
... and 34 more
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2087   +/-   ##
=========================================
  Coverage     85.01%   85.01%           
- Complexity     2488     2493    +5     
=========================================
  Files           237      237           
  Lines          7349     7349           
  Branches        388      388           
=========================================
  Hits           6248     6248           
  Misses          871      871           
  Partials        230      230           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bitwiseman bitwiseman force-pushed the spotless-sort-members branch from 232d5d3 to 1de7a50 Compare April 13, 2025 23:10
@bitwiseman bitwiseman force-pushed the spotless-sort-members branch from 1de7a50 to 73ab6c4 Compare April 13, 2025 23:14
@bitwiseman bitwiseman merged commit 362faaf into hub4j:main Apr 14, 2025
12 of 13 checks passed
@bitwiseman bitwiseman deleted the spotless-sort-members branch April 14, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant