Skip to content

Cleanup names and enforce naming conventions #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 13, 2025

Conversation

bitwiseman
Copy link
Member

Description

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED" locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

Copy link

codecov bot commented Apr 12, 2025

Codecov Report

Attention: Patch coverage is 87.65432% with 30 lines in your changes missing coverage. Please review.

Project coverage is 85.01%. Comparing base (9a4f6ec) to head (f65c149).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/org/kohsuke/github/GHIssue.java 55.55% 4 Missing ⚠️
...va/org/kohsuke/github/GHPullRequestFileDetail.java 0.00% 4 Missing ⚠️
...ain/java/org/kohsuke/github/GHCheckRunBuilder.java 57.14% 3 Missing ⚠️
src/main/java/org/kohsuke/github/GHProject.java 40.00% 3 Missing ⚠️
...org/kohsuke/github/GHPullRequestReviewComment.java 85.71% 2 Missing and 1 partial ⚠️
...rc/main/java/org/kohsuke/github/GHProjectCard.java 60.00% 0 Missing and 2 partials ⚠️
src/main/java/org/kohsuke/github/GHThread.java 50.00% 2 Missing ⚠️
...ava/org/kohsuke/github/GHAppInstallationsPage.java 0.00% 1 Missing ⚠️
.../main/java/org/kohsuke/github/GHArtifactsPage.java 0.00% 1 Missing ⚠️
src/main/java/org/kohsuke/github/GHAsset.java 75.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2084      +/-   ##
============================================
+ Coverage     84.42%   85.01%   +0.59%     
- Complexity     2455     2488      +33     
============================================
  Files           237      237              
  Lines          7344     7349       +5     
  Branches        388      388              
============================================
+ Hits           6200     6248      +48     
+ Misses          915      871      -44     
- Partials        229      230       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bitwiseman bitwiseman merged commit 2067be3 into hub4j:main Apr 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant