Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Bump minimum supported Node.js version to v16 #1369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hyperupcall
Copy link

@hyperupcall hyperupcall commented Oct 13, 2023

Short description of what this resolves:

Node.js v16 just hit EOL a few months ago. I saw that Node.js v16 was still in CI, which is even older, so I didn't make v18 the minimum since it seems this repository lags behind.

Let me know if I should make v18 the minimum - that's one less upgrade in the future and less worry about using dependencies that could set their minimums to v18.

Proposed changes:

  • Remove Node.js v14 from CI
  • Use v16 in "engines" configuration (v16 is already used in .nvmrc)
  • Update tsconfig.json to use v16 preset
    • As a result of this (changing module/moduleResolution), some updates to the imports had to be made
  • Upgrade to latest TypeScript since we depent on tsconfig.json options of recent TypeScript version
  • This is a BREAKING CHANGE and would require a major version update

@github-actions github-actions bot added dependencies Pull requests that update a dependency file cli Relates to HTMLHint's command-line interface automation Changes done to the .github folder labels Oct 13, 2023
@hyperupcall hyperupcall changed the title refactor: Bump minimum supported Node.js version to v16 refactor!: Bump minimum supported Node.js version to v16 Oct 13, 2023
@hyperupcall hyperupcall changed the title refactor!: Bump minimum supported Node.js version to v16 refactor!: bump minimum supported Node.js version to v16 Oct 13, 2023
@hyperupcall hyperupcall changed the title refactor!: bump minimum supported Node.js version to v16 refactor!: Bump minimum supported Node.js version to v16 Oct 13, 2023
@hyperupcall hyperupcall force-pushed the hyperuepcall-min-16 branch 2 times, most recently from e389029 to f6ece36 Compare October 13, 2023 04:05
@hyperupcall hyperupcall marked this pull request as draft October 16, 2023 10:57
@hyperupcall hyperupcall marked this pull request as ready for review October 19, 2023 08:43
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: Patch coverage is 72.46377% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 97.94%. Comparing base (22c5716) to head (5442446).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1369      +/-   ##
==========================================
- Coverage   99.07%   97.94%   -1.13%     
==========================================
  Files           2        2              
  Lines        1627     1658      +31     
  Branches      332      341       +9     
==========================================
+ Hits         1612     1624      +12     
- Misses         15       34      +19     
Files Coverage Δ
src/cli/parse-glob.ts 100.00% <100.00%> (ø)
dist/htmlhint.js 97.94% <72.05%> (-1.13%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21022c6...5442446. Read the comment docs.

@hyperupcall
Copy link
Author

hyperupcall commented Oct 26, 2023

I know this is a big PR, and I haven't contributed to repository before, so I'm not sure if it would be preferred merging this #1369 first, or my smaller MRs like #1370 and #1368

This comment was marked as duplicate.

@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Mar 17, 2024
@coliff coliff added bot:stale Issue marked as stale because there was no activity keep-unstale The issue will not be marked as stale by the stale-bot and removed bot:stale Issue marked as stale because there was no activity labels Mar 22, 2024
@coliff coliff reopened this Mar 22, 2024
@stale stale bot removed the bot:stale Issue marked as stale because there was no activity label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Changes done to the .github folder cli Relates to HTMLHint's command-line interface dependencies Pull requests that update a dependency file keep-unstale The issue will not be marked as stale by the stale-bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants