Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: avoid unintentional polling #327

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ro0gr
Copy link

@ro0gr ro0gr commented Feb 8, 2021

...for multiple handlers attached to a single scroll container.

fixes #320

with multiple handlers
// test triggering that handler
assert.strictEqual(scrollable.scrollTop, 0, `The scrollable is initially unscrolled`);

assert.false(scrollHandlers.isPolling, 'polling is inactive');
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only assert which is fixed by this PR

@ro0gr ro0gr marked this pull request as ready for review March 1, 2023 14:50
@ro0gr ro0gr changed the title avoid concurrent passiveHandler and poll avoid concurrent unintentional polling Mar 1, 2023
@ro0gr ro0gr changed the title avoid concurrent unintentional polling Bugfix: avoid unintentional polling Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application test times out when two vertical collections share a containerSelector
1 participant