Bugfix: avoid unintentional polling #327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0gr
commented
Feb 8, 2021
ro0gr
commented
Feb 8, 2021
with multiple handlers
ro0gr
commented
Mar 1, 2023
| // test triggering that handler | ||
| assert.strictEqual(scrollable.scrollTop, 0, `The scrollable is initially unscrolled`); | ||
|
|
||
| assert.false(scrollHandlers.isPolling, 'polling is inactive'); |
There was a problem hiding this comment.
this is the only assert which is fixed by this PR
ro0gr
changed the title
ro0gr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...for multiple handlers attached to a single scroll container.
fixes #320