-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application test times out when two vertical collections share a containerSelector #320
Comments
Maybe related: html-next/ember-raf-scheduler#5 |
Related: #197 |
I spent some time debugging this with some teammates. We were able to identify the root cause of this issue, which is a faulty piece of conditional logic inside the scroll handler util. When passive event listeners are supported, and two vertical-collection instances share the same container element, then the first vc instance adds a passive event listener, but the second vc We only want to add the event listener once and want to avoid polling altogether when passive event listeners are supported. Starting the polling pushed an extra job into the ember-raf-scheduler which was never I'll plan to submit a PR with the fix and a test in the next week or two. |
Hello! |
Minimal reproduction repo: https://github.com/steveszc/vertical-collection-shared-container-reproduction
When a route template contains two vertical-collections that share a common containerSelector (ex a scrollable
body
) a test that visits that route will timeout on theawait visit()
. The vertical-collections work as expected when using the app, however.The text was updated successfully, but these errors were encountered: