-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random username if none given #701
Open
cameronangliss
wants to merge
62
commits into
hsahovic:master
Choose a base branch
from
cameronangliss:random-username-if-none-given
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Random username if none given #701
cameronangliss
wants to merge
62
commits into
hsahovic:master
from
cameronangliss:random-username-if-none-given
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #701 +/- ##
==========================================
+ Coverage 83.38% 84.00% +0.61%
==========================================
Files 39 42 +3
Lines 3918 4444 +526
==========================================
+ Hits 3267 3733 +466
- Misses 651 711 +60 |
… they are invalid, if at all possible
…nv into singles-env
… random-username-if-none-given
… random-username-if-none-given
…om-username-if-none-given
…poke-env into random-username-if-none-given
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #704
We change the default behavior of
Player
's username generation to make a random lowercase alphanumeric string of length 10. This makes it so that if one is trying to, say, pickle their environment in separatePipe
s (whichsupersuit
does for parallel environment running stuff) you don't have username conflicts of the parallel environments due to the fact that each environment doesn't have access to the sameCONFIGURATION_FROM_PLAYER_COUNTER
object.With 10 characters, the likelihood of 2 random players having an overlapping name is 1/(36^10) = 0.000000000000027351112%