Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restart issue #228

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Fix restart issue #228

wants to merge 12 commits into from

Conversation

houjun
Copy link
Member

@houjun houjun commented Feb 13, 2025

Related Issues / Pull Requests

#227

Description

IDIOMS should be initialized before calling metadata_index_recover

What changes are proposed in this pull request?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected; for instance, examples in this repository must be updated too)
  • This change requires a documentation update

Checklist:

  • My code modifies existing public API, or introduces new public API, and I updated or wrote docstrings
  • I have commented my code
  • My code requires documentation updates, and I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

* Fix a thread race issue that may cause memory error when larger than cache max size data is transferred

* Add a test that writes more data than server cache size

* Fix CI run command
@houjun houjun requested a review from a team as a code owner February 13, 2025 23:43
@houjun
Copy link
Member Author

houjun commented Feb 13, 2025

@zhangwei217245 After the proposed change, the server can restart normally, but it seems to take a long time even with just a few objects, can you look into this?

./bin/pdc_server.exe &
./bin/vpicio
./bin/close_server
./bin/pdc_server.exe restart

...

==PDC_SERVER[0]: Server restarted from saved session, successfully loaded 1 containers, 8 objects, 0 regions...
[IDIOMS_Index_Recover_0] Timer to recover index = 21149388.0000 microseconds

==PDC_SERVER[0]: max cache size: 68719476736
==PDC_SERVER[0]: Successfully established connection to 0 other PDC servers
==PDC_SERVER[0]: total startup time = 21.336065
==PDC_SERVER[0]: Server ready!

@jeanbez jeanbez added the type: bug Something isn't working label Feb 14, 2025
jeanbez and others added 5 commits March 27, 2025 10:26
* Check that return value of PDC_Client_init in PDC_init

* Change return to 0

This will make is simpler when merging #233 (comment)

---------

Co-authored-by: Jean Luca Bez <[email protected]>
* Changed all printf to use pdc logger

Also removed large blocks of comments and chanegd the pdc logger
to print the file name, function, and line number.

* Change typo of LOG_INFO to LOG_ERROR

* Correct grammar from fail -> failed

* update grammer succesfully close -> successfully closed

* switch type of LOG_INFO to LOG_ERROR

* Add logging docs and fix some LOG_INFO->LOG_JUST_PRINT

* update clang formatting

---------

Co-authored-by: Jean Luca Bez <[email protected]>
@jeanbez jeanbez requested a review from sbyna March 31, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants