Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSB-439 feature: invite link with SMTP optional #4078

Merged
merged 17 commits into from
Jun 27, 2024
Merged

HSB-439 feature: invite link with SMTP optional #4078

merged 17 commits into from
Jun 27, 2024

Conversation

mirarifhasan
Copy link
Contributor

@mirarifhasan mirarifhasan commented May 20, 2024 •
edited
Loading

Closes HSB-439

Description

This PR

  • Makes mailer-module optional
  • Makes mailer-module more configurable

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

Nil

@mirarifhasan mirarifhasan requested a review from balub May 20, 2024 17:48
@mirarifhasan mirarifhasan self-assigned this May 20, 2024
@mirarifhasan mirarifhasan changed the base branch from main to next May 21, 2024 14:31
@mirarifhasan mirarifhasan marked this pull request as ready for review May 21, 2024 14:31
@JoelJacobStephen JoelJacobStephen mentioned this pull request May 24, 2024
Merged
4 tasks
@mirarifhasan mirarifhasan changed the title HSB-43 feature: invite link with SMTP optional HSB-439 feature: invite link with SMTP optional May 27, 2024
balub
balub reviewed May 27, 2024
View reviewed changes
.env.example Outdated Show resolved Hide resolved
balub
balub requested changes May 27, 2024
View reviewed changes
.env.example Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
packages/hoppscotch-backend/src/mailer/mailer.service.ts Show resolved Hide resolved
packages/hoppscotch-backend/src/mailer/mailer.service.ts Show resolved Hide resolved
packages/hoppscotch-backend/src/mailer/mailer.module.ts Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
packages/hoppscotch-backend/src/admin/infra.resolver.ts Outdated Show resolved Hide resolved
@balub balub self-requested a review May 27, 2024 09:51
@balub
Copy link
Member

balub commented May 27, 2024

EMAIL does not get added back to the VITE_ALLOWED_AUTH_PROVIDERS infra-config when SMTP is enabled again after being disabled.

@balub
Copy link
Member

balub commented Jun 27, 2024

@mirarifhasan run a pnpm i to fix all issues with the pnpm lock file.

@balub
Copy link
Member

balub commented Jun 27, 2024

@mirarifhasan there is a small issue where EMAIL can be enabled for SSO even when SMTP is diabled.

balub
balub approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@balub balub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@balub balub merged commit fa2f73e into next Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balub balub balub approved these changes

@ankitsridhar16 ankitsridhar16 Awaiting requested review from ankitsridhar16

@AndrewBastin AndrewBastin Awaiting requested review from AndrewBastin

@liyasthomas liyasthomas Awaiting requested review from liyasthomas

Assignees

@mirarifhasan mirarifhasan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirarifhasan @balub