-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: switch workspace after creation #4015
refactor: switch workspace after creation #4015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nivedin When a new workspace is created, the dropdown which allows users to switch workspaces is not updated. Even after switching to the personal workspace, it is not updated.
Screen.Recording.2024-04-30.at.10.49.14.AM.mov
4b37c2d
to
056f21b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are few type issues and some unnecessary imports in few components such as SaveRequest.vue
. Rest looks good to me. Also please bring in the latest changes from release/2024.3.3
to this PR.
packages/hoppscotch-common/src/components/environments/index.vue
Outdated
Show resolved
Hide resolved
056f21b
to
010266f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 💯
if (team) { | ||
collectionsType.value.type = "team-collections" | ||
teamCollectionAdapter.changeTeamID(team.teamID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we need all the changes that happens when a new team is selected to go into one place.
its okey for now. we might update it in the new workspace system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
d939f87
to
7f64a74
Compare
Co-authored-by: amk-dev <[email protected]>
Closes HFE-483
Description
This PR add's a improvement in the workspace creation flow where the workspace is automatically switched to the created one.
Checks