Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(script-api): add variables.replaceIn method with tests #3993

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shipko
Copy link
Contributor

@shipko shipko commented Apr 21, 2024

Closes #3726

Description

This PR is first step for supporting variables.replaceIn method in Hoppscotch.
I have added:

  • GUID

  • randomUUID

  • timestamp

  • isoTimestamp

  • Not Completed

  • Completed

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@shipko
Copy link
Contributor Author

shipko commented Apr 28, 2024

@JoelJacobStephen can you review this pr?

@JoelJacobStephen
Copy link
Contributor

@JoelJacobStephen can you review this pr?

@shipko Sure.
@jamesgeorge007, I would like you to have a look at this PR first before I review it..

@JoelJacobStephen
Copy link
Contributor

@shipko We are currently working on a scripting API revamp. We will only be able to review your PR after that. Hence we will defer this PR till that is done.

@JoelJacobStephen JoelJacobStephen added the future Scheduled to near future label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future Scheduled to near future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: add pw.variables.replaceIn method in js-sandbox
2 participants