Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added a shortcut Ctrl/Cmd+Enter to import cURL #3933

Draft
wants to merge 4 commits into
base: release/2024.3.0
Choose a base branch
from

Conversation

anwarulislam
Copy link
Member

Description

This pull request introduces a convenient shortcut to streamline the process of importing the curl. By pressing Ctrl (or Cmd on macOS) and Enter simultaneously, you can import curl in Hoppscotch

  • Not Completed
  • Completed

@anwarulislam anwarulislam changed the base branch from main to release/2024.3.0 March 25, 2024 13:08
@anwarulislam anwarulislam changed the title feat: added a shortcut Ctrl/Cmd+Enter to import curl feat: added a shortcut Ctrl/Cmd+Enter to import cURL Mar 25, 2024
@nivedin
Copy link
Member

nivedin commented Mar 27, 2024

while pressing Cmd+Enter the curl is imported successfully also the request is sent, is this the intendant behaviour @anwarulislam

@anwarulislam
Copy link
Member Author

@nivedin not intended. I will push a fix now

Copy link
Contributor

@JoelJacobStephen JoelJacobStephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the behaviour mentioned by @nivedin which still persists, the rest looks good to me. Once the behaviour is changed, we can go ahead with merging this PR.

@anwarulislam
Copy link
Member Author

@JoelJacobStephen do you still see the issue @nivedin mentioned? I fixed the issue by this commit 5bbdc58

@JoelJacobStephen
Copy link
Contributor

JoelJacobStephen commented Apr 9, 2024

@JoelJacobStephen do you still see the issue @nivedin mentioned? I fixed the issue by this commit 5bbdc58

@anwarulislam Yes, it is still present. When clicking the button, it doesn't send the request. But when entering CMD + Enter, It imports and sends the request.

Screen.Recording.2024-04-09.at.5.26.16.PM.mov

@JoelJacobStephen
Copy link
Contributor

Based on our internal discussion, we will be deferring this PR for a later release as we plan to implement the same functionality to other modals as well. Hence this will be converted to a draft PR for now.

@JoelJacobStephen JoelJacobStephen marked this pull request as draft April 17, 2024 13:02
@JoelJacobStephen JoelJacobStephen added the future Scheduled to near future label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future Scheduled to near future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants