[bug]: Setting body type to none sets the content type in the request to application/x-www-form-urlencoded #3685 #3906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to application/x-www-form-urlencoded hoppscotch#3685
anwarulislam
requested changes
Mar 19, 2024
Comment on lines
193
to
208
|
|
||
| // When the user clicks to change the content type | ||
| @click=" | ||
| () => { | ||
| // If the selected content type is 'none' | ||
| if (contentTypeItem === 'none') { | ||
| // Set the body.contentType to null | ||
| body.contentType = null | ||
| // And remove the 'Content-Type' header | ||
| headers.value = headers.value.filter(header => header.key.toLowerCase() !== 'content-type'); | ||
| } else { | ||
| // Otherwise, set the body.contentType as usual | ||
| body.contentType = contentTypeItem | ||
| } | ||
| hide() | ||
| } |
There was a problem hiding this comment.
You have included Vue template code inside the script tag. Please revise your pull request.
There was a problem hiding this comment.
Thank you for your feedback. I’ve moved the Vue template code from the <script> tag to the tag as suggested. Please review the updated code.
… to application/x-www-form-urlencoded hoppscotch#3685
… to application/x-www-form-urlencoded hoppscotch#3685
|
@ialloyd, I could not reproduce the issue. I see it's working completely fine. Can you please tell me the process to reproduce this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the 'Content-Type' header was incorrectly set to 'application/x-www-form-urlencoded' when the body type was set to 'none'. The changes ensure that the 'Content-Type' header is removed as expected in this scenario.
I would appreciate if you could review the changes and provide your valuable feedback. Thank you!