fix: documentation is not being generated on GQL #3730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Encountered this issue as well when I was working on #3723, glad I wasn't the only one |
amk-dev
requested changes
Jan 17, 2024
|
Updated to |
amk-dev
approved these changes
Jan 17, 2024
jamesgeorge007
approved these changes
Jan 18, 2024
AndrewBastin
changed the base branch from
release/2023.12.2
to
release/2023.12.3
AndrewBastin
force-pushed
the
fix/gql-docs-render
branch
from
ec61361
to
2a8dc72
Compare
JoelJacobStephen
pushed a commit
to JoelJacobStephen/hoppscotch
that referenced
this pull request
Jan 30, 2024
Co-authored-by: Liyas Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HFE-380
Description
Updated the
resolveRootTypefunction to correctly handle GraphQL types that do not have anofTypeproperty. The function now uses a while loop to traverse theofTypechain until it reaches a type that does not contain any other types (i.e., its ofType property is null). This ensures that the function always returns the correct root type for any given GraphQL type.