Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm chart #3606

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add helm chart #3606

wants to merge 2 commits into from

Conversation

shipko
Copy link
Contributor

@shipko shipko commented Nov 29, 2023

Closes #3007

Description

I want to share my helm chart for hopscotch. It consists in the small chart for three components: backend, frontend, admin panel.
This chart is working in my infrastructure. But I know there is no limit to perfection. So I open for your feedback

  • Not Completed
  • Completed

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Copy link

@Radoslaw-Kutylowski Radoslaw-Kutylowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm not in any way affiliated with Hoppscotch, but as a potential user of this I'd like to propose a couple changes:

  1. Allow customizing environment variables through values - for a lot of customers the currently supplied ones would not work. I'm especially worried about DATABASE_URL, JWT_SECRET and MAILER_SMTP_URL in helm/backend/templates/_env.tpl
  2. Is there a specific reason why You made 3 charts with one deployment each, instead of one chart with 3 deployments? I think that would be easier to use.
  3. I'd love for the chart to support securityContext - even the same way how it handles resources.

Let me know what you think, I'd be happy to collaborate to implement these changes if you're okay with them.
Sincerely,
Radosław Kutyłowski

@shipko
Copy link
Contributor Author

shipko commented Dec 7, 2023

@Radoslaw-Kutylowski, Hi!
Thank you for your comment.

  1. I didn't understand the question. Could you describe it in more detail.
  2. I think that 3 charts may more flexible for deploying in current infrastructure (for my self-hosted version). But I agree that aall in one version will be more prefer
  3. Of course, chart is under development, it will be added in the future.

@Radoslaw-Kutylowski
Copy link

Great, instead of trying to describe it, I'll make a pull request to your fork so you can review the actual changes, I think it will be easier this way. Have a nice day :)

@daniil-titov-indriver
Copy link

hi, @Radoslaw-Kutylowski , @shipko

you both did a really good job and it seems to me you are really close to the finish lane to implement production ready hoppscotch installations

do you have any updates with helm chart, guys?

@shipko
Copy link
Contributor Author

shipko commented May 1, 2024

@daniil-titov-indriver, hi!
At this moment I don't have any updates. I concentrate to fixing some errors in product. My helm chart is working, but maybe another question is quality of this Chart. Yes it need to refactor, but I can do this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: k8s deployment strategy - Helm Chart
3 participants