Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/selfhosted desktop backend auth #3561

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rokibulislaam
Copy link

@rokibulislaam rokibulislaam commented Nov 16, 2023

Closes #3544

Description

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

Dependencies Added

Desktop - package.json
Desktop - Cargo.toml

Enivonrment Variables Added

  • DESKTOP_DEEP_LINK_URL

PR Features

  • Implemented a custom fetch urql exchange to utilize taur's HTTP client, injecting access_token and refresh_token into the cookie from tauri's store.
  • Created a WebSocket wrapper using tauri-plugin-websocket-api, enabling support for subscriptions-transport-ws while injecting cookies from tauri's store.

@rokibulislaam
Copy link
Author

@AndrewBastin @liyasthomas

Let me know if this aligns with the approach you intended to use for handling GraphQL subscriptions (websockets) and HTTP calls through Tauri.

Please review the code and propose any modifications that may better suit your implementation preferences.

Peace.

@AndrewBastin
Copy link
Member

Hi @rokibulislaam !

Thanks for the contribution!

I will look into the PR, but it may take some time as I am dealing with multiple other things. Sorry about that.

@PujanTalukder
Copy link

@rokibulislaam
Have been waiting for the rest of the implementation. Running self hosted desktop application was impossible before

Copy link

@dhwanish-3 dhwanish-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required optimization

@rokibulislaam
Copy link
Author

Required optimization

@dhwanish-3 can you give some more idea? Or leave comments in the code?

Copy link

@dhwanish-3 dhwanish-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a mistake
Sorry for the inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Backend auth support for Hoppscotch Desktop
4 participants