Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "prepare" npm script so this works when depended on via git link #224

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Sep 24, 2024

I added my fork of this repo to my project as a npm git dependency, but it didn't work until I did this.

https://docs.npmjs.com/cli/v10/using-npm/scripts#life-cycle-scripts

NOTE: If a package being installed through git contains a prepare script, its dependencies and devDependencies will be installed, and the prepare script will be run, before the package is packaged and installed.

I added my fork of this repo to my project as a npm git dependency, but it didn't work until I did this.

https://docs.npmjs.com/cli/v10/using-npm/scripts#life-cycle-scripts
> NOTE: If a package being installed through git contains a prepare script, its dependencies and devDependencies will be installed, and the prepare script will be run, before the package is packaged and installed.
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@gobengo

Thanks! Merging.

@yusukebe yusukebe merged commit b7c03de into honojs:main Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants