fix: default routes include well-known URIs with several path segments #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[RFC6920 defines](https://www.rfc-editor.org/rfc/rfc6920.html#section-8.1) some well-known routes like: http://example.com/.well-known/ni/sha-256/f4OxZX_x_FO5LcGBSKHWXfwtSx-j1ncoSt3SABJtkGk Note that there are three path segments after the `/.well-known/` path prefix. In my honox /app directory, I crated `/app/routes/.well-known/ni/[alg]/[val].tsx` but it didn't work. (it does work if I directly nest at `/app/routes/.well-known/[val.tsx]`). Based on cursory local testing of this change. I think this change accomodates for several path segments beyond `/.well-known/` as well as only one.
|
wdyt @yusukebe ? |
|
I'll check it later. |
yusukebe
changed the title
|
Thanks! Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC6920 defines some well-known routes like:
http://example.com/.well-known/ni/sha-256/f4OxZX_x_FO5LcGBSKHWXfwtSx-j1ncoSt3SABJtkGk
Note that there are three path segments after the
/.well-known/path prefix.In my honox /app directory, I crated
/app/routes/.well-known/ni/[alg]/[val].tsxbut it didn't work. (it does work if I directly nest at/app/routes/.well-known/[val].tsx).Based on cursory local testing of this change. I think this change accomodates for several path segments beyond
/.well-known/as well as only one.