Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: serialize element in props. (not only children) #162

Merged
merged 1 commit into from
May 3, 2024

Conversation

usualoma
Copy link
Member

In #56 we can now pass child components to children.

The documentation for next.js stated the following.

You're not limited to the children prop. you can use any prop to pass JSX.

https://nextjs.org/docs/app/building-your-application/rendering/composition-patterns

Honox also allows components to be passed for any key in this PR.

@usualoma usualoma force-pushed the feat/serialize-more-component branch 3 times, most recently from 049513f to 7fdbac3 Compare May 3, 2024 01:13
@usualoma usualoma force-pushed the feat/serialize-more-component branch from 7fdbac3 to 86a9c64 Compare May 3, 2024 02:26
@usualoma usualoma marked this pull request as ready for review May 3, 2024 02:27
@usualoma
Copy link
Member Author

usualoma commented May 3, 2024

@yusukebe Would you please review?

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented May 3, 2024

@usualoma

Thanks! Merging now.

@yusukebe yusukebe merged commit 481e900 into honojs:main May 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants