perf(types): replace intersection with union to get better perf

honojs · Sep 23, 2024 · 60bffbb · 60bffbb
1 parent e1eb98d
commit 60bffbb
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/types.ts b/src/types.ts
@@ -146,7 +146,11 @@ export interface HandlerInterface<
  >(
  path: P,
  handler: H<E2, MergedPath, I, R>
- ): Hono<E, S & ToSchema<M, MergePath<BasePath, P>, I, MergeTypedResponse<R>>, BasePath>
+ ): Hono<
+ E,
+ ExcludeEmptyObject<S | ToSchema<M, MergePath<BasePath, P>, I, MergeTypedResponse<R>>>,
+ BasePath
+ >
 
  // app.get(handler x 3)
  <
@@ -1988,6 +1992,8 @@ type IntersectNonAnyTypes<T extends any[]> = T extends [infer Head, ...infer Res
  ? IfAnyThenEmptyObject<EnvOrEmpty<Head>> & IntersectNonAnyTypes<Rest>
  : {}
 
+type ExcludeEmptyObject<T> = T extends {} ? ({} extends T ? never : T) : T
+
 ////////////////////////////////////////
 ////// //////
 ////// FetchEvent //////