fix(serve-static): use application/octet-stream if the mime type is n…

…ot detected (#3415)
honojs · Sep 17, 2024 · 27a57c3 · 27a57c3
1 parent 0edb243
commit 27a57c3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/src/middleware/serve-static/index.test.ts b/src/middleware/serve-static/index.test.ts
@@ -143,6 +143,7 @@ describe('Serve Static Middleware', () => {
  expect(res.status).toBe(200)
  expect(res.headers.get('Content-Encoding')).toBe('br')
  expect(res.headers.get('Vary')).toBe('Accept-Encoding')
+ expect(res.headers.get('Content-Type')).toBe('application/octet-stream')
  expect(await res.text()).toBe('Hello in static/hello.unknown.br')
  })
 

diff --git a/src/middleware/serve-static/index.ts b/src/middleware/serve-static/index.ts
@@ -99,13 +99,8 @@ export const serveStatic = <E extends Env = Env>(
  }
 
  if (content) {
- const mimeType = options.mimes
- ? getMimeType(path, options.mimes) ?? getMimeType(path)
- : getMimeType(path)
-
- if (mimeType) {
- c.header('Content-Type', mimeType)
- }
+ const mimeType = (options.mimes && getMimeType(path, options.mimes)) || getMimeType(path)
+ c.header('Content-Type', mimeType || 'application/octet-stream')
 
  if (options.precompressed && (!mimeType || COMPRESSIBLE_CONTENT_TYPE_REGEX.test(mimeType))) {
  const acceptEncodingSet = new Set(