Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(k8sagent): retry watcher if it stops; fixes #416 #418

Merged
merged 1 commit into from
Jun 3, 2024
Merged

fix(k8sagent): retry watcher if it stops; fixes #416 #418

merged 1 commit into from
Jun 3, 2024

Conversation

lizthegrey
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Retries polling if the watcher fails.

@lizthegrey lizthegrey requested a review from a team as a code owner June 3, 2024 00:14
MikeGoldsmith
MikeGoldsmith approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @lizthegrey 🎉

@MikeGoldsmith MikeGoldsmith merged commit ff01400 into main Jun 3, 2024
4 checks passed
@MikeGoldsmith MikeGoldsmith deleted the lizf.retry-polling branch June 3, 2024 13:25
@TylerHelmuth TylerHelmuth added the status: oncall Flagged for awareness from Honeycomb Telemetry Oncall label Jul 9, 2024
@robbkidd robbkidd self-assigned this Sep 17, 2024
@robbkidd robbkidd mentioned this pull request Sep 19, 2024
Merged
@robbkidd robbkidd removed the status: oncall Flagged for awareness from Honeycomb Telemetry Oncall label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees

@robbkidd robbkidd

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lizthegrey @MikeGoldsmith @robbkidd @TylerHelmuth