Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime device permissions update in runc v1.2.x #3921

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

sairon
Copy link
Member

@sairon sairon commented Mar 11, 2025

Add missing patch and update for latest runc version to fix losing device permissions when new devices are added in runtime.

  • buildroot b079a02a9a...3914f8cad5 (2):

    package/runc: add patch for extended default allowed devices in v1.2.4
    package/runc: add missing patch to fix device permissions update

Fixes #3915

Summary by CodeRabbit

  • Chores
    • Updated a core underlying component to its latest version, helping maintain the system's current state and ensuring continued stability.

@sairon
Copy link
Member Author

sairon commented Mar 11, 2025

Buildroot PR: home-assistant/buildroot#81

Copy link

coderabbitai bot commented Mar 11, 2025

📝 Walkthrough

Walkthrough

This pull request updates the commit reference for the buildroot subproject. The update replaces the previous commit identifier b079a02a9a8606ef8cde7a5e640af47a9a4ff104 with a new identifier 3914f8cad5a87a3aa1ba3aa04733887a869b87fe, indicating that the subproject has moved to a more recent state.

Changes

File Change Summary
buildroot Updated subproject commit from b079a02a9a8606ef8cde7a5e640af47a9a4ff104 to 3914f8cad5a87a3aa1ba3aa04733887a869b87fe

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 56f03b2 and 8aae5c0.

📒 Files selected for processing (1)
  • buildroot (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • buildroot

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
buildroot (1)

1-1: Ensure Commit Update Aligns with the Fix

The subproject commit reference has been updated to cb7c9d6fccacb898f67028f4199d5efa37729efd. Please verify that this new commit includes the missing patch for the device permissions update and the extended default allowed devices for runc v1.2.4, as intended by the PR objectives.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a1d2b7 and 56f03b2.

📒 Files selected for processing (1)
  • buildroot (1 hunks)

Add missing patch and update for latest runc version to fix losing device
permissions when new devices are added in runtime.

* buildroot b079a02a9a...3914f8cad5 (2):
  > package/runc: add patch for extended default allowed devices in v1.2.4
  > package/runc: add missing patch to fix device permissions update

Fixes #3915
@sairon sairon force-pushed the fix-runc-device-update branch from 56f03b2 to 8aae5c0 Compare March 11, 2025 14:21
@sairon sairon merged commit 04debe2 into dev Mar 11, 2025
3 checks passed
@sairon sairon deleted the fix-runc-device-update branch March 11, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

15.0rc1: RaspberryMatic add-on stops working due to Operation not permitted
2 participants