-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve log clarity and fix typos #3896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
In the future, when the bot marks your PR as draft, mark it as ready for review after resolving the issues again. In the OS repo the opened PR still stands out but it could get lost in other home-assistant repositories.
Warning Rate limit exceeded@sairon has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 27 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe pull request updates console messages in three Home Assistant scripts. In the CLI script, the warning text is slightly rephrased. In the configuration script, informational and error messages related to configuration import (from USB stick and boot partition) and firmware updates have been refined and expanded with a success message. The Supervisor script has its error message adjusted. None of the changes affect the script logic or control flow. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
While playing around with USB Configuration I noticed that the logs were a bit confusing.
Also made some changes for clarity in hassos-cli and hassos-supervisor while I was at it.
Hope it helps!
Summary by CodeRabbit