-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Added starline run sensor (#35726)" #36432
base: next
Are you sure you want to change the base?
Revert "Added starline run sensor (#35726)" #36432
Conversation
This reverts commit 0244173.
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request modifies the documentation for the Starline integration in Home Assistant, specifically updating the description of available binary sensors. The change involves removing the "running state" sensor from the list of binary sensors, resulting in a revised list that includes hand brake, hood, trunk, alarm status, doors lock state, handsfree, neutral, and moving ban status. The overall documentation structure remains unchanged, maintaining the integration's core functionality. Changes
The changes are purely documentation-related, with no modifications to the actual integration's code or functionality. The documentation now reflects a slightly reduced set of binary sensor options for the Starline integration. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)source/_integrations/starline.markdown (1)
The binary sensors list modification is clean and maintains proper formatting. Let's verify that all references to "running state" have been properly removed: ✅ Verification successfulRevert of "running state" is complete and consistent The verification shows that:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for any remaining references to "running state" in the codebase
# that might need to be updated for consistency
# Search for "running state" in documentation and integration code
rg -i "running state" --type yaml --type markdown --type python
Length of output: 96 Script: #!/bin/bash
# Let's try a more comprehensive search without file type restrictions
rg -i "running state"
# Also search for potential variations
rg -i "running.*status"
Length of output: 2959 Script: #!/bin/bash
# Let's check the actual starline integration code to verify the binary sensors
fd starline --type f --exec rg -l "binary_sensor"
# Also check for any references to running in the starline integration
fd starline --type f --exec rg -l "running"
Length of output: 134 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This reverts commit 0244173.
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
starline
integration, removing "running state" from the list of available sensors.