Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calendar card to allow variable height, better multi-day event support #23191

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

hoverduck
Copy link

@hoverduck hoverduck commented Dec 6, 2024

Proposed change

This allows the Calendar card to behave the same way as the Calendar panel from the sidebar, where multi-day events are displayed in blocks spanning the calendar rather than on the start date only.

This revisits a design decision made in #14660, where the behavior was allowed to differentiate. The argument in that PR was that the Calendar Card was too cramped to effectively display the multi-day events, so I've also added an option to choose the card's height.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

type: calendar
entities:
  - calendar.local_test
multi_day: true
height: 900

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hoverduck

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft December 6, 2024 19:53
@home-assistant
Copy link

home-assistant bot commented Dec 6, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@wendevlin
Copy link
Contributor

Hi @hoverduck

Can you please split this up in 2 PRs one for height and one for all-day

Setting a height in px is very specific and I would keep it as a yaml option only.

Your editor options labels are plain text, they need to be translated.

I know you havn't changed anything in ha-full-calendar but the full day events doesn't work well with my real data. When it's over multiple rows it shows in the first row only. When the title is wider then the cell it just overlaps.
At this state this can't be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants