Translation support for device automation extra fields #20567
Conversation
| ) || schema.name; | ||
| ) || | ||
| localize( | ||
| `component.${trigger.domain}.device_automation.extra_fields.${schema.name}` |
There was a problem hiding this comment.
You will have to load these translations somewhere, or do the device automation controls already load them?
There was a problem hiding this comment.
I think it is already loaded since the backends strings.jsons
{
"device_automation": {
"condition_type": {...}
"trigger_type": {...}
}
}keys are already loaded too. I'm not sure where this happens though 😬.
There was a problem hiding this comment.
The automation editor loads them:
| // Returns a callback for ha-form to calculate labels per schema object | ||
| return (schema) => | ||
| return (schema): string => | ||
| localize( |
There was a problem hiding this comment.
Shouldnt the order be reversed? The component should be able to override the default translations I think?
There was a problem hiding this comment.
Yes, that makes sense. Do you know where these default translations are used?
"extra_fields": {
"above": "Above",
"below": "Below",
"for": "Duration (optional)",
"zone": "[%key:ui::panel::config::automation::editor::triggers::type::zone::label%]"
},I would think of sensor domain, but for the "zone" key I'm not sure. Should it maybe be moved to backend (like components/sensor/strings.json)?
There was a problem hiding this comment.
Yes, it should be moved to the backend.
There was a problem hiding this comment.
I moved all of this to the backend and removed the translations from the frontend. home-assistant/core@c20bd32
Also moved the ComputeLabelCallback functions to a common module so it can be used by conditions and actions too.
farmio
changed the title
Proposed change
Add translation support for integration specific device trigger extra fields.
Core PR to allow new keys in
strings.json: home-assistant/core#115892This can be tested with a core-branch adding a new device trigger for "Sun" with some dummy extra_fields
home-assistant/core#115846
Given an integrations
strings.json{ "device_automation": { "trigger_type": { "test_sun_trigger": "Sun trigger 🌞" }, "extra_fields": { "bool": "Boolean", "time": "Time ⏰", "number": "Number 🔢", "datetime": "Date and time", "duration": "Duration ⏳", "cv_bool": "Config validation boolean", "plain_bool": "Plain boolean" }, "extra_fields_descriptions": { "bool": "Boolean helper text", "time": "A nice time", "number": "Some number between 10 and 100", "datetime": "Today may be the day 📅", "duration": "Duration ⏳" } } }Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: