-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geocaching integration feature updates #134017
base: dev
Are you sure you want to change the base?
Conversation
Nearby caches
Add trackable entities, and some additional cache fields
removed comments
Conflig flow
…n, and connect the user config with HA backend
Multi code configuration for trackables, and connect configuration with backend
Add nearby cache count and radius to configuration
Replace cache find count entity with found date and found switch
Add trackable location entity and journey log attributes
Cache and Trackable URLs
Updates in line with new api library version
Add unit test for device_tracker.py
added tests for sensors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @marc7s,@belgien,@ClumpyAbbe
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @Sholofly, @reinder83, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Proposed change
This update adds several new features to the Geocaching integration, enabled by the release of version 0.3.0 of the
geocachingapi
package, changelog. It adds support for Geocaches and Trackables, creating a device for each cache or trackable containing the relevant entities for each item. Here is an example of a device generated for a Trackable, with entities related to that device:We have provided a README for the integration, containing some example templates for presenting caches and trackables on a dashboard.
Type of change
Additional information
reverse_geocode
. We are not sure how this is handled in HA, but we did not add that dependency to therequirements
in the manifest. We recloned the repository and rebuilt the dev container and it still worked, so we assume dependencies of requirements are installed automaticallyChecklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: