Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scale support to lamarzocco #133335

Merged
merged 8 commits into from
Dec 20, 2024

Conversation

zweckj
Copy link
Member

@zweckj zweckj commented Dec 16, 2024

Breaking change

Proposed change

Linea Mini models can be connected to special LM branded Acaia Lunar scales for brew-by-weight functionality. Those scales do not connect to the normal app, but only to the LM machines (and therefore don't work with the Acaia integration). Only one scale can be configured per machine at a time.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@zweckj zweckj marked this pull request as ready for review December 16, 2024 08:33
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 18, 2024 18:23
@zweckj zweckj marked this pull request as ready for review December 18, 2024 20:24
@home-assistant home-assistant bot requested a review from joostlek December 18, 2024 20:24
@joostlek joostlek merged commit bddd862 into home-assistant:dev Dec 20, 2024
34 checks passed
@zweckj zweckj deleted the lamarzocco/scale-support-2 branch December 20, 2024 11:25
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants