Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config subentry support to device registry #128157

Merged

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Oct 11, 2024

Proposed change

Add config subentry support to device registry

This is a follow-up to #117355

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (config) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of config can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign config Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@emontnemery
Copy link
Contributor Author

emontnemery commented Dec 12, 2024

Frontend is approved: home-assistant/frontend#23160

@emontnemery emontnemery force-pushed the device_registry_subentry_support branch from 08781ec to a52b6d5 Compare December 12, 2024 19:17
@emontnemery emontnemery marked this pull request as ready for review December 12, 2024 19:17
@emontnemery emontnemery requested a review from a team as a code owner December 12, 2024 19:17
@emontnemery emontnemery force-pushed the device_registry_subentry_support branch from 39d91b9 to 1040f49 Compare December 16, 2024 14:32
@emontnemery emontnemery marked this pull request as ready for review December 16, 2024 14:37
@emontnemery emontnemery force-pushed the device_registry_subentry_support branch from 594cb67 to f46159d Compare December 18, 2024 09:09
@emontnemery emontnemery marked this pull request as draft December 18, 2024 09:38
@emontnemery emontnemery force-pushed the device_registry_subentry_support branch from f46159d to 5e0102d Compare January 20, 2025 18:43
@emontnemery emontnemery changed the base branch from dev to config_subentries_feature_2 January 20, 2025 18:43
@emontnemery emontnemery marked this pull request as ready for review January 20, 2025 18:43
@emontnemery emontnemery force-pushed the device_registry_subentry_support branch from 361c653 to 4aeab3f Compare January 20, 2025 21:05
@emontnemery emontnemery merged commit c0bc38f into config_subentries_feature_2 Jan 23, 2025
46 checks passed
@emontnemery emontnemery deleted the device_registry_subentry_support branch January 23, 2025 18:49
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants