Skip to content

Make AuthenticationDao suspensible #5555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TimoPtr
Copy link
Collaborator

@TimoPtr TimoPtr commented Jul 16, 2025

Summary

After enabling StrictMode in #5483 I found out that we are doing many db calls on the main thread where we shouldn't. It most probably causes some ANR. This PR is related to the AuthenticationDao all the DAO methods should be marked as suspend.

Part of #5520

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

@TimoPtr
Copy link
Collaborator Author

TimoPtr commented Jul 16, 2025

@dshokouhi @jpelgrom do you know a way to quickly test that it is not broken?

@jpelgrom
Copy link
Member

Iframe in the dashboard which requires HTTP auth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants