Disable ha_launcher by default and hide it in automotive

[TimoPtr]

Summary

The new feature about being able to use HA as a launcher was not properly setup in the SettingsFragment. It was enabled by default where it should have been disabled by default.

We also don't want to expose this feature in the automotive variant of the app.

Checklist

• New or updated tests have been added to cover the changes following the testing guidelines.
• The code follows the project's code style and best_practices.
• The changes have been thoroughly tested, and edge cases have been considered.
• Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

CC @fpetrovski

[jpelgrom]

Using this PR to fix some weirdness from the launcher setting: I propose reverting the change from this suggestion, so always passing PackageManager.DONT_KILL_APP as the flag.
It prevents the current behavior where disabling the setting in the app results in the app restarting, which looks like a crash, and doesn't seem to cause any issues (the launcher apps list in Settings still updates immediately, and swiping home returns you to a normal launcher).

[jpelgrom]

Other changes get a ✅ from me

[fpetrovski]

Using this PR to fix some weirdness from the launcher setting: I propose reverting the change from this suggestion, so always passing PackageManager.DONT_KILL_APP as the flag. It prevents the current behavior where disabling the setting in the app results in the app restarting, which looks like a crash, and doesn't seem to cause any issues (the launcher apps list in Settings still updates immediately, and swiping home returns you to a normal launcher).

I have another launcher app besides Samsung's OneUI and when the app closed I got the prompt to chose a default launcher, but if you don't have another launcher app, I see how it can be perceived as a crash.

Also the Automotive variant didn't even cross my mind. I'll remember that for some future contribution

[jpelgrom]

I have another launcher app besides Samsung's OneUI and when the app closed I got the prompt to chose a default launcher, but if you don't have another launcher app, I see how it can be perceived as a crash.

The behavior I'm describing happens even without changing the default launcher. Just toggling it on and off is enough.

[TimoPtr]

I have another launcher app besides Samsung's OneUI and when the app closed I got the prompt to chose a default launcher, but if you don't have another launcher app, I see how it can be perceived as a crash.

The behavior I'm describing happens even without changing the default launcher. Just toggling it on and off is enough.

Reverted