-
-
Notifications
You must be signed in to change notification settings - Fork 750
Edge to edge support for webviews using <View> bars #5390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Edge to edge support for webviews using <View> bars #5390
Conversation
@Gregman-js I'm working on migrating the webViews to compose so that we can handle this into one place. |
@Gregman-js here is the PR #5419 for the migration to Compose. It will be easier to apply your fix in compose and it will work for the other screens too. You are more than welcome to review the PR :) |
37c8344
to
2e73d2b
Compare
@Gregman-js The PR about compose has been merged. Could you impl your proposal in compose only and apply it to the two places that uses a WebView. FYI we can't get the version of a server without being fully authenticated so in the onboarding we cannot assume that the frontend support edge to edge yet. |
It seems that in some case we have the capability to get the version of the server through mDNS Line 100 in d340830
Then it won't work for ppl that set the address manually. But it would cover most of the case which is nice. It's important because sometimes the users are making the setup of their home assistant instances directly on their phone so we want to make sure that edge to edge is properly handled to not hide anything. |
Summary
enableEdgeToEdge()
for all<View>
on top and bottom of<Webview>
InsetsUtil.kt
Android >= 15 will use Views background color
Android < 15 will use Views background colors and statusBarColor on top
Checklist
Screenshots
Link to pull request in documentation repositories
User Documentation: home-assistant/companion.home-assistant#
Developer Documentation: home-assistant/developers.home-assistant#
Any other notes